[Bookings][Part 1] Booking details screen #16168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
Collaborator
|
|
Base automatically changed from
woomob-1374-update-networking-layer-to-support-fetching-bookings
to
trunk
September 24, 2025 08:29
RafaelKayumov
force-pushed
the
WOOMOB-1236-booking-details-screen
branch
from
238a3d3 to
0336bd1
Compare
RafaelKayumov
changed the title
RafaelKayumov
changed the title
itsmeichigo
approved these changes
Sep 26, 2025
Contributor
itsmeichigo
left a comment
itsmeichigo
left a comment
There was a problem hiding this comment.
Looks good 👍 I left some nit-picking in the comments.
| import SwiftUI | ||
|
|
||
| /// periphery: ignore - will be used after Booking list is ready | ||
| final class BookingDetailsViewController: UIHostingController<BookingDetailsView> { |
Contributor
There was a problem hiding this comment.
Can we use the BookingDetailsView directly in BookingTabView? If so I think this hosting controller would be redundant.
Comment on lines
31
to
34
| let appointmentDate = Self.appointmentDateFormatter.string(from: booking.startDate) | ||
| let appointmentTimeFrame = [ | ||
| Self.appointmentTimeFrameFormatter.string(from: booking.startDate), | ||
| Self.appointmentTimeFrameFormatter.string(from: booking.endDate) |
Contributor
There was a problem hiding this comment.
Nit: these can be simplified:
Suggested change
| let appointmentDate = Self.appointmentDateFormatter.string(from: booking.startDate) | |
| let appointmentTimeFrame = [ | |
| Self.appointmentTimeFrameFormatter.string(from: booking.startDate), | |
| Self.appointmentTimeFrameFormatter.string(from: booking.endDate) | |
| let appointmentDate = booking.startDate.formatted(date: .numeric, time: .omitted) | |
| let appointmentTimeFrame = [ | |
| booking.startDate.formatted(date: .omitted, time: .shortened), | |
| booking.endDate.formatted(date: .omitted, time: .shortened) |
| ) | ||
|
|
||
| let appointmentDetailsSection = Section( | ||
| headerText: "Appointment Details".uppercased(), |
Contributor
There was a problem hiding this comment.
Nit: please ensure to localize this.
| let status: [Status] | ||
|
|
||
| init(_ booking: Booking) { | ||
| bookingDate = Self.dateFormatter.string(from: booking.startDate) |
Contributor
There was a problem hiding this comment.
Nit: similar comment as above about formatting date in a simpler way.
| } | ||
|
|
||
| var body: some View { | ||
| RefreshablePlainList(action: { |
Contributor
There was a problem hiding this comment.
Nit: this type seems outdated. Since we're targeting iOS 17 minimum now, please consider using ScrollView with refreshable for simplicity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: WOOMOB-1236
Description
The PR adds the draft for a "Booking details" screen. The added view and view model is currently a skeleton and doesn't yet have a data binding.
The view and view controller is not yet used in the app. To check out the appearance - use the Xcode, navigate to the
BookingDetailsViewfile and open the canvas with a preview.Current PR only implements the header section and the "Appointment details" section. Other sections and data binding will be implemented in the upcoming PRs.
BookingDetailsViewControllerhas hosting view controller forBookingDetailsViewBookingDetailsViewas SwiftUI view carrying the screen contentBookingDetailsViewModelrepresenting the view state of a booking details screen.TitleAndTextFieldRowto have configurable title and value fonts and color. Reuses it for content rows in "Appointment details" section.Steps to reproduce
N/A
Testing information
To check out the current appearance - use the Xcode, navigate to the
BookingDetailsViewfile and open the canvas with a preview.Screenshots
RELEASE-NOTES.txtif necessary.